Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework tabs in user profile #2753

Closed
yangwao opened this issue Apr 3, 2022 · 6 comments
Closed

Rework tabs in user profile #2753

yangwao opened this issue Apr 3, 2022 · 6 comments
Labels
$ ~<50usd A-profile related to profile section A-refactoring Refactoring stuff, make code more readable, mitigating tech debt p2 core functionality, or is affecting 60% of app

Comments

@yangwao
Copy link
Member

yangwao commented Apr 3, 2022

I guess with upcoming bug tackling in

Seems some tabs can't be seen if the address they did not create NFTs and see for example collections.
This issue is for someone to help to refactor how profile tabs are appearing based on users' holding.

For example, at Shawns Lin I try opened https://deploy-preview-2751--koda-nuxt.netlify.app/rmrk/u/FXUxw9Xp98gTzrU2z63D2G92kcx1oznd6xYa8WdqRgTcEDo?tab=holdings and I got redirected to collected.

Test as many possible scenarios if things are working.

  • Users with or without NFTs
  • Users with or without collected NFTs

Bounty could be higher if refactor is well made!

@yangwao yangwao added $ ~<50usd p2 core functionality, or is affecting 60% of app A-profile related to profile section labels Apr 3, 2022
@prachi00
Copy link
Member

prachi00 commented Apr 3, 2022

@yangwao I'll see what I can do

@yangwao
Copy link
Member Author

yangwao commented Apr 3, 2022

@yangwao I'll see what I can do

merged #2725 into #2751 so let me see if it is fixed , but even though I see someone could refactor it if not.

@yangwao yangwao added the A-refactoring Refactoring stuff, make code more readable, mitigating tech debt label Apr 3, 2022
@Jarsen136 Jarsen136 mentioned this issue Apr 6, 2022
17 tasks
@prachi00
Copy link
Member

prachi00 commented Apr 7, 2022

@yangwao this is still an issue right?

@yangwao
Copy link
Member Author

yangwao commented Apr 7, 2022

don't know, maybe test to find out :)

@prachi00
Copy link
Member

prachi00 commented Apr 7, 2022

@prachi00
Copy link
Member

this doesn't seem to be an issue anymore, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd A-profile related to profile section A-refactoring Refactoring stuff, make code more readable, mitigating tech debt p2 core functionality, or is affecting 60% of app
Projects
None yet
Development

No branches or pull requests

2 participants