Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: GalleryItem.vue cleanup 馃Ч #2866

Closed
kkukelka opened this issue Apr 15, 2022 · 4 comments 路 Fixed by #2867
Closed

Refactor: GalleryItem.vue cleanup 馃Ч #2866

kkukelka opened this issue Apr 15, 2022 · 4 comments 路 Fixed by #2867
Assignees
Labels
$ ~<50usd A-refactoring Refactoring stuff, make code more readable, mitigating tech debt enhancement New feature or request

Comments

@kkukelka
Copy link
Member

kkukelka commented Apr 15, 2022

Is your feature request related to a problem?

Since we abstracted a lot of logic into Base component there is much cleanup to do

Todo:

  • Remove unnecessary poll requests
  • Simplify overcomplicated logic
  • Remove unused imports, properties and css
  • Lazy Import some components
@kkukelka kkukelka added enhancement New feature or request A-refactoring Refactoring stuff, make code more readable, mitigating tech debt labels Apr 15, 2022
@kkukelka kkukelka self-assigned this Apr 15, 2022
@kkukelka kkukelka added the $ ~<50usd label Apr 15, 2022
@yangwao
Copy link
Member

yangwao commented Apr 15, 2022

I guess that every second fetch is to avoid double spending 馃槄

馃摕 @vikiival

@roiLeo
Copy link
Contributor

roiLeo commented Apr 15, 2022

I guess that every second fetch is to avoid double spending 馃槄

Wouldn't be better to fetch data until an action is made?

@Jarsen136
Copy link
Contributor

Wouldn't be better to fetch data until an action is made?

However, you don't know when should fetch data if the action is submitted by others : )
IMO, for the gallery item, poll fetch is necessary. Or maybe need a long connect? like WebSocket

@kkukelka
Copy link
Member Author

kkukelka commented Apr 16, 2022

I guess that every second fetch is to avoid double spending 馃槄

馃摕 @vikiival

Oh damn I didn't think about that at all. I will reintroduce the smartquery then
added additional comment to explain it for further occasions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd A-refactoring Refactoring stuff, make code more readable, mitigating tech debt enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants