Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GalleryCardList in Gallery #2966

Closed
1 task done
vikiival opened this issue May 6, 2022 · 9 comments
Closed
1 task done

Use GalleryCardList in Gallery #2966

vikiival opened this issue May 6, 2022 · 9 comments
Labels
bug Something isn't working S-blocked-✋

Comments

@vikiival
Copy link
Member

vikiival commented May 6, 2022

What happened?

Currently we have duplicated implementation for the same stuff on GalleryCard.vue

Please reproduce in steps

Moreover, the hover effect does not work on screens like profile or collection detail.

Expected Behavior

[BLOCKED] By first basilisk impl

What browsers are you seeing the problem on?

No response

Are you logged in?

No response

At which address did you encounter bug?

No response

Screenshots

~

Relevant log output

~

Payment link for reward

https://kodadot.xyz/transfer/?target=%3CMy_Kusama_Address_check_https://github.com/kodadot/nft-gallery/blob/main/CONTRIBUTING.md#creating-your-ksm-address%3E

Code of Conduct

  • I agree to follow this project's Code of Conduct
@vikiival vikiival added bug Something isn't working S-blocked-✋ labels May 6, 2022
@prachi00
Copy link
Member

prachi00 commented May 6, 2022

I'll take this

@kodabot
Copy link
Collaborator

kodabot commented May 6, 2022

ASSIGNED - @prachi00 🔒 LOCKED -> Sunday, May 8th 2022, 05:21:05 UTC -> 36 hours

@vikiival
Copy link
Member Author

vikiival commented May 6, 2022

@petersopko is this some edge case ?

@petersopko
Copy link
Contributor

@petersopko is this some edge case ?

Alright, issues labelled "blocked" won't be up for grabs by the bot, I'll think of some message tomorrow and add this to the mix.

@vikiival
Copy link
Member Author

vikiival commented May 7, 2022

is this some edge case ?

I meant that: Why are issues without a bounty label are locked for 36hrs?

@petersopko
Copy link
Contributor

is this some edge case ?

I meant that: Why are issues without a bounty label are locked for 36hrs?

Ah, @yangwao was asking about the blocked label at the same time. I thought you meant that.

Issues without bounty labels are locked for 24hrs by default. Frequent contributors to the repository (10+ merged PRs) get a 50% time boost for assignments, therefore, 36hrs for unlabeled ones -> #2932

@kodabot
Copy link
Collaborator

kodabot commented May 8, 2022

ASSIGNMENT EXPIRED - @prachi00 has been unassigned.

@vikiival
Copy link
Member Author

vikiival commented May 8, 2022

Nice bot

@yangwao
Copy link
Member

yangwao commented Jul 18, 2022

@yangwao yangwao closed this as completed Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working S-blocked-✋
Projects
None yet
Development

No branches or pull requests

5 participants