Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests after basilisk merge to fix builds #3117

Closed
yangwao opened this issue Jun 8, 2022 · 7 comments · Fixed by #3128
Closed

Fix tests after basilisk merge to fix builds #3117

yangwao opened this issue Jun 8, 2022 · 7 comments · Fixed by #3128
Assignees
@KngZhi
Labels
$ ~<50usd bug Something isn't working p1 preventing everyone from using app

Comments

@yangwao
Copy link
Member

yangwao commented Jun 8, 2022

Found one thing that needs to be fixed, asap so someone could feel free to take charge of that.

image

Originally posted by @yangwao in #3060 (comment)
@yangwao yangwao added bug Something isn't working $ ~<50usd p1 preventing everyone from using app labels Jun 8, 2022
@KngZhi
Copy link
Contributor

KngZhi commented Jun 8, 2022

👋

@kodabot
Copy link
Collaborator

kodabot commented Jun 8, 2022

ASSIGNED - @KngZhi 🔒 LOCKED -> Friday, June 10th 2022, 24:01:27 UTC -> 36 hours

@yangwao
Copy link
Member Author

yangwao commented Jun 8, 2022

@KngZhi fetch main , there were recent merges

@KngZhi
Copy link
Contributor

KngZhi commented Jun 8, 2022

okay, just get to the computer.

@KngZhi fetch main , there were recent merges

@KngZhi
Copy link
Contributor

KngZhi commented Jun 8, 2022 •
edited
Loading

Already fixed. Okay to close.

8a64881 by @vikiival
174384e by @roiLeo

@roiLeo
Copy link
Contributor

roiLeo commented Jun 8, 2022

Already fixed. Okay to close.

Tests still don't pass
Capture d’écran 2022-06-08 à 3 31 51 PM

@KngZhi
Copy link
Contributor

KngZhi commented Jun 8, 2022

checking.

@KngZhi KngZhi mentioned this issue Jun 8, 2022
Merged
18 tasks
@roiLeo roiLeo changed the title Lint error after basilisk merge to fix builds Fix tests after basilisk merge to fix builds Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KngZhi KngZhi

Labels
$ ~<50usd bug Something isn't working p1 preventing everyone from using app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: shopping action test KngZhi/nft-gallery
4 participants
@yangwao @roiLeo @KngZhi @kodabot