Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name down components we should split into smaller reusable components #3616

Open
yangwao opened this issue Jul 29, 2022 · 0 comments
Open

Name down components we should split into smaller reusable components #3616

yangwao opened this issue Jul 29, 2022 · 0 comments
Labels
A-refactoring Refactoring stuff, make code more readable, mitigating tech debt p3 non-core, affecting less than 40%

Comments

@yangwao
Copy link
Member

yangwao commented Jul 29, 2022 •
edited
Loading

We should avoid having long and extensive components, which are, let's say, over 100-200 LOC.
If possible, we should rework them into smaller components which are more accessible to trackable and have fewer merge conflicts.

You can check yourself biggest files visually here https://mango-dune-07a8b7110.1.azurestaticapps.net/?repo=kodadot%2Fnft-gallery

Ref
@yangwao yangwao added A-refactoring Refactoring stuff, make code more readable, mitigating tech debt p3 non-core, affecting less than 40% labels Jul 29, 2022
@yangwao yangwao changed the title Name down components we should be splited into smaller reusable components Name down components we should split into smaller reusable components Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-refactoring Refactoring stuff, make code more readable, mitigating tech debt p3 non-core, affecting less than 40%
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yangwao