Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to vite on production #3908

Closed
yangwao opened this issue Sep 2, 2022 · 13 comments
Closed

Migrate to vite on production #3908

yangwao opened this issue Sep 2, 2022 · 13 comments
Labels
$$ ~51-150usd A-nuxt A-vite hacktoberfest p2 core functionality, or is affecting 60% of app

Comments

@yangwao
Copy link
Member

yangwao commented Sep 2, 2022 •
edited
Loading

It seems's Vite issue is resolved meanwhile?

If yes, it would be nice to finally drop webpack and speed up stuff! :)

As webpack4 used by Nuxt is ancient ("@types/webpack": "^4.41.32") we want to upgrade anyway

Ref
@yangwao yangwao added $ ~<50usd p3 non-core, affecting less than 40% A-nuxt labels Sep 2, 2022
@yangwao yangwao mentioned this issue Sep 2, 2022
Closed
@kkukelka
Copy link
Member

kkukelka commented Sep 7, 2022

👋

@kodabot
Copy link
Collaborator

kodabot commented Sep 7, 2022

ASSIGNED - @kkukelka 🔒 LOCKED -> Friday, September 9th 2022, 02:11:29 UTC -> 36 hours

@kodabot
Copy link
Collaborator

kodabot commented Sep 9, 2022

ASSIGNMENT EXPIRED - @kkukelka has been unassigned.

@preschian
Copy link
Member

stuck on this error, it seems the current version of @nuxt/i18n isn't compatible with the bridge
Screen Shot 2022-10-05 at 16 59 58

@preschian preschian mentioned this issue Oct 5, 2022
Closed
5 tasks
@kkukelka
Copy link
Member

kkukelka commented Oct 5, 2022

wow, how did you solve the postcss warning?

@preschian
Copy link
Member

wow, how did you solve the postcss warning?

I didn't get the postcss warning yet, maybe because I removed some config after I renamed nuxt.config.js to nuxt.config.ts

If anyone knows how to bypass build.rollupOptions.external error, please modify the PR #4079. I think it would be better if we could fix this together

@yangwao
Copy link
Member Author

yangwao commented Jan 10, 2023

Has anyone idea how to go through this one?

@yangwao yangwao added the A-vite label Jan 10, 2023
@yangwao yangwao mentioned this issue Jan 10, 2023
Closed
@yangwao yangwao added p2 core functionality, or is affecting 60% of app and removed p3 non-core, affecting less than 40% labels Jan 10, 2023
@yangwao yangwao mentioned this issue Jan 18, 2023
Closed
@yangwao yangwao added p3 non-core, affecting less than 40% and removed p2 core functionality, or is affecting 60% of app labels Jan 24, 2023
@yangwao yangwao added p2 core functionality, or is affecting 60% of app $$ ~51-150usd and removed p3 non-core, affecting less than 40% $ ~<50usd labels Feb 6, 2023
@yangwao
Copy link
Member Author

yangwao commented Apr 25, 2023

Bump, has some packages changed so we can move this forward?

@yangwao
Copy link
Member Author

yangwao commented Jun 1, 2023

If anyone take this one?

@roiLeo
Copy link
Contributor

roiLeo commented Jun 1, 2023 •
edited
Loading

If anyone take this one?

Why? I don't think it's needed since Vite is already built-in with Nuxt3

Capture d’écran 2023-06-01 à 3 37 23 PM

@yangwao
Copy link
Member Author

yangwao commented Jun 1, 2023

oh! nice.

So we can remove webpack & webpack dependencies and close this one?

https://github.com/kodadot/nft-gallery/blob/main/package.json#L147
https://github.com/kodadot/nft-gallery/blob/main/package.json#L145
https://github.com/kodadot/nft-gallery/blob/main/package.json#L194

@roiLeo
Copy link
Contributor

roiLeo commented Jun 1, 2023 •
edited
Loading

https://github.com/kodadot/nft-gallery/blob/main/package.json#L145

This one looks like to be used to transpile (same goes for babel-loader), will be removed after Nuxt3

https://github.com/kodadot/nft-gallery/blob/main/package.json#L147

Not needed will be move to sentry plugin

https://github.com/kodadot/nft-gallery/blob/main/package.json#L194

will be remove (nuxt-bridge dependent)

You can close this in favor of #2690

@yangwao
Copy link
Member Author

yangwao commented Jun 1, 2023

Continue to

@yangwao yangwao closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$$ ~51-150usd A-nuxt A-vite hacktoberfest p2 core functionality, or is affecting 60% of app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Draft: enable vite kodadot/nft-gallery
5 participants
@preschian @yangwao @roiLeo @kkukelka @kodabot