Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove infinity scroll on collection on the top #4089

Closed
yangwao opened this issue Oct 7, 2022 · 2 comments · Fixed by #4093
Closed

Remove infinity scroll on collection on the top #4089

yangwao opened this issue Oct 7, 2022 · 2 comments · Fixed by #4093
Assignees
Labels
$ ~<50usd A-collection work being done collection view p2 core functionality, or is affecting 60% of app

Comments

@yangwao
Copy link
Member

yangwao commented Oct 7, 2022

At https://beta.kodadot.xyz/movr/collection/0xb6e9e605aa159017173caa6181c522db455f6661?page=23

When the user wants to scroll to the top, it adds extra pictures, which is not good behaviour.
Same when the user go the next page, it resets me to the middle, add an extra 12(?) on the top and an extra 12(?) to the bottom.

The intended behaviour would be to remove the infinite scroll on the top, so the user can browse to the top and keep the infinity scroll only on the bottom.
On pagination would be desired no to reset the user to the middle of the collection but keep the user at the same position so they can click on the previous and next page afterwards.

Goal is to not reset state for the user where is located once it browse pages back and forth

Screen.Recording.2022-10-07.at.14.35.55.mov
@yangwao yangwao added $ ~<50usd p2 core functionality, or is affecting 60% of app A-collection work being done collection view labels Oct 7, 2022
@Jarsen136
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Oct 7, 2022

ASSIGNED - @Jarsen136 🔒 LOCKED -> Sunday, October 9th 2022, 03:16:54 UTC -> 36 hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd A-collection work being done collection view p2 core functionality, or is affecting 60% of app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants