Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redesign: Chart Component and Tabs section #4235

Closed
Tracked by #4111
preschian opened this issue Nov 2, 2022 · 7 comments · Fixed by #4355
Closed
Tracked by #4111

redesign: Chart Component and Tabs section #4235

preschian opened this issue Nov 2, 2022 · 7 comments · Fixed by #4355
Labels
$$ ~51-150usd A-item p2 core functionality, or is affecting 60% of app redesign

Comments

@preschian
Copy link
Member

preschian commented Nov 2, 2022

requirements: #4111 (comment)

@preschian preschian mentioned this issue Nov 2, 2022
8 tasks
@preschian preschian added p2 core functionality, or is affecting 60% of app redesign labels Nov 2, 2022
@preschian preschian changed the title redesign: Chart Component redesign: Chart Component and Tabs section Nov 2, 2022
@Jarsen136
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Nov 2, 2022

ASSIGNED - @Jarsen136 🔒 LOCKED -> Friday, November 4th 2022, 04:01:44 UTC -> 36 hours

@preschian
Copy link
Member Author

hi @Jarsen136, seems like we can create a chart wrapper under histoire (put component under libs/ui / @kodadot1/brick package) and using this package https://vue-chartjs.org/guide/ the package seems good and support vue2/vue3. wdyt?

for tabs, I'm still not sure about it. But, if you can use tabs component from https://vue2.oruga.io/components/Tabs.html#examples without affecting our current CSS/buefy it would be good

@Jarsen136
Copy link
Contributor

hi @Jarsen136, seems like we can create a chart wrapper under histoire (put component under libs/ui / @kodadot1/brick package) and using this package https://vue-chartjs.org/guide/ the package seems good and support vue2/vue3. wdyt?

for tabs, I'm still not sure about it. But, if you can use tabs component from https://vue2.oruga.io/components/Tabs.html#examples without affecting our current CSS/buefy it would be good

That's a good idea. I will give it a shot.

@kodabot
Copy link
Collaborator

kodabot commented Nov 4, 2022

ASSIGNMENT EXPIRED - @Jarsen136 has been unassigned.

@preschian
Copy link
Member Author

hi @Jarsen136, any updates for this task? I added a tabs component from oruga in this task #4305 so you can continue from there once the PR merged

@Jarsen136
Copy link
Contributor

hi @Jarsen136, any updates for this task?

Not yet. I will work on it these days.

I added a tabs component from oruga in this task #4305 so you can continue from there once the PR merged

Ok, I will check it.

@yangwao yangwao added the $$ ~51-150usd label Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ ~51-150usd A-item p2 core functionality, or is affecting 60% of app redesign
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants