-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Largest Contentful Paint (LCP) #4765
Comments
thought it was going to be a problem, the svgs are quite large. Is there anything I can change? |
hhmm 🤔 I guess nothing wrong with the svgs stuff, maybe we can tackle this from code. let's ask the other first maybe it's possible with just CSS. unfortunately, I'm not really good with CSS |
i think that would be the best approach, but it would have to match pretty closely :D svgs are generally not meant to be exported with effects on top. The effects should be applied in css afterwards |
we can try to:
not sure it's the best option |
IMO, we could try to inline the svg file to the js/html, to avoid fetch too many pic while open landing page. They cost a lot time at the network fetching.
It may be not that easy to match the design with css. |
👋 |
ASSIGNED - @Jarsen136 🔒 LOCKED -> Saturday, January 21st 2023, 04:26:52 UTC -> 36 hours |
nice, ping me if anything |
oohh, yes, this may help to improve that 🚀🚀🚀 |
ASSIGNMENT EXPIRED - @Jarsen136 has been unassigned. |
I would close this PR #4780 (inline svg file) for two reasons:
|
and what about this? @Jarsen136, the only pain would be only with positioning |
In this way, we still need to request some smaller svg and make some transforms by CSS. I guess it would not make too much difference in the LCP time, because there is |
ah okay, dont understand this tbh :D |
LCP: https://web.dev/lcp/
how to check LCP on chrome devtools:
Slow 3G
network underNetwork
tabs in chrome devtoolsPerformance
tabstimings
section to see the contentthis is our LCP score on the homepage in the previous 21 days
The text was updated successfully, but these errors were encountered: