Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer urls #5185

Closed
vikiival opened this issue Mar 6, 2023 · 2 comments · Fixed by #5187
Closed

Clearer urls #5185

vikiival opened this issue Mar 6, 2023 · 2 comments · Fixed by #5187
Assignees

Comments

@vikiival
Copy link
Member

vikiival commented Mar 6, 2023

make it so hitting enter without searching for anything would not write search query param into the url

Originally posted by @daiagi in #5170 (comment)

@Jarsen136 Jarsen136 self-assigned this Mar 6, 2023
@kodabot
Copy link
Collaborator

kodabot commented Mar 6, 2023

ASSIGNED - @Jarsen136 🔒 LOCKED -> Wednesday, March 8th 2023, 24:16:05 UTC -> 36 hours

@Jarsen136
Copy link
Contributor

make it so hitting enter without searching for anything would not write search query param into the url

We should not write the search query if the keyword is empty. That's right.
However, we still need to do searching again once hitting enter, because it could remove the search results that come from other non-empty keywords.

@Jarsen136 Jarsen136 mentioned this issue Mar 6, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants