Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In artist profile: Not showing all collections created by the artist #5466

Open
1 task done
JustLuuuu opened this issue Apr 1, 2023 · 6 comments
Open
1 task done
Labels
🧙‍♀️ - bug-hunt A-profile related to profile section A-rmrk2 bug Something isn't working p2 core functionality, or is affecting 60% of app

Comments

@JustLuuuu
Copy link
Member

What happened?

Kusama Dark Side and Ku colletion is not showing between collections created by this artist.

Zluchkayaa is the creator of the 2 mentioned collections:
image

In her profile. If you click on collections, you see only 3. They are all on RMRK2.

Screenshot 2023-04-01 at 11 25 47

you can see those NFTs between NFTs in her profile but not in collections. Not sure why

Please reproduce in steps

Open for example [this](Kusama Dark Side ) collection and chceck creator.

Then open this artist and look at collections.

Expected Behavior

Show all collections created by artist

What browsers are you seeing the problem on?

Chrome

At which address did you encounter bug?

beta.kodadot.xyz

Are you logged in?

None

Which wallet you are using?

No response

Screenshots

Relevant log output

No response

Payment link for reward

https://kodadot.xyz/transfer/?target=%3CMy_Kusama_Address_check_https://github.com/kodadot/nft-gallery/blob/main/CONTRIBUTING.md#creating-your-ksm-address%3E

Code of Conduct

  • I agree to follow this project's Code of Conduct
@JustLuuuu JustLuuuu added bug Something isn't working p2 core functionality, or is affecting 60% of app A-rmrk2 labels Apr 1, 2023
@JustLuuuu JustLuuuu changed the title Be descriptive and short In artist profile: Not showing all collections created by the artist Apr 1, 2023
@JustLuuuu
Copy link
Member Author

Another example: RubenTopia:

This collections are created by him but you cannot see them in his profile: https://beta.kodadot.xyz/rmrk2/collection/c095ca1430a05e7d6b-TOPIA?page=1
https://beta.kodadot.xyz/rmrk2/collection/c095ca1430a05e7d6b-7?page=1
....

@yangwao
Copy link
Member

yangwao commented Apr 3, 2023

ou nou, this is bad ass

@yangwao
Copy link
Member

yangwao commented Apr 5, 2023

I guess I've cracked mystery. Thing is that they've been collection issuer on RMRKv1, but as they did migrated it, they did not claimed it from RMRK Migrator address which is actually issuer on RMRKv2, that's case for mints at least and I sense with collections it is somehow.. very close to same.. dum dum dumdumdum

I sense this will result in some uberhacking and maybe it's not even bug, yet RMRK2 inconsistencies "on-chain"

Probably same

@yangwao yangwao added p3 non-core, affecting less than 40% 🧙‍♀️ - bug-hunt A-profile related to profile section and removed p2 core functionality, or is affecting 60% of app labels Apr 5, 2023
@yangwao
Copy link
Member

yangwao commented Apr 16, 2023

Apparently it's that issuer of collection is RMRK Official or RMRK Migrator and we are showing current owner, where in profile we are showing only issued collection by that address, so mistake is bit in collection rather in profile. We can maybe glue something to work it..

We could add new tab "Owned Collections" to profile and we will reflect in #2009 it better for redesign to be smarter in UI

@vikiival
Copy link
Member

vikiival commented Apr 16, 2023

The problem is that we show that creator is currentOwner and not and an issuer

Therefore created by should be issuer
and if current owner is not equal to issuer show
owned by

Screenshot 2023-04-16 at 15 40 35

query x($id: String!) {
  collectionEntityById(id: $id) {
    id
    name
    issuer
    currentOwner
  }
}

variables

{
  "id": "e0b9bdcc456a36497a-SQSQ"
}

Result

{
  "data": {
    "collectionEntityById": {
      "id": "e0b9bdcc456a36497a-SQSQ",
      "name": "Squid Squad",
      "issuer": "HeyRMRK7L7APFpBrBqeY62dNhFKVGP4JgwQpcog2VTb3RMU",
      "currentOwner": "FAyqRVLZmXVUU9pNeG8w8SxS5xRgN8FRGeWLL6u9S32TMHc"
    }
  }
}

@yangwao yangwao added p2 core functionality, or is affecting 60% of app and removed p3 non-core, affecting less than 40% labels Apr 16, 2023
@vikiival
Copy link
Member

same applies for

{
  "data": {
    "collectionEntityById": {
      "id": "7e982817a2d2575031-Y007N",
      "name": "Kusama Dark Side",
      "issuer": "EXZLG911C35TBhi2b2m3G1pEFhn5NvEhyZxXHye6ffX2b77",
      "currentOwner": "FSJkXLHuWYfB8DYejjFKX4bkFjb7dMt9RvVpq6D5LUQLY6x"
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧙‍♀️ - bug-hunt A-profile related to profile section A-rmrk2 bug Something isn't working p2 core functionality, or is affecting 60% of app
Projects
None yet
Development

No branches or pull requests

3 participants