Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too much graphql calls on activity tab #5574

Closed
yangwao opened this issue Apr 9, 2023 · 1 comment · Fixed by #5608
Closed

Too much graphql calls on activity tab #5574

yangwao opened this issue Apr 9, 2023 · 1 comment · Fixed by #5608
Assignees
@daiagi
Labels
A-collection work being done collection view A-rmrk2 bug Something isn't working graphql p1 preventing everyone from using app

Comments

@yangwao
Copy link
Member

yangwao commented Apr 9, 2023 •
edited
Loading

seems when you open activity tab fires over 2k+ requests.

I guess we should lazy load queries on and embrace put them into Graphql and not like REST style to generate lot of requests

  • holders
  • flippers
  • activity

https://canary.kodadot.xyz/rmrk2/collection/daf9e25824d4bd9357-KUBOTS/activity

Screen.Recording.2023-04-09.at.18.19.26.mov
@yangwao yangwao added p2 core functionality, or is affecting 60% of app A-collection work being done collection view graphql A-rmrk2 labels Apr 9, 2023
This was referenced Apr 9, 2023
Open
Closed
@yangwao yangwao changed the title Too much graphql calls on activity Too much graphql calls on activity tab Apr 9, 2023
@yangwao yangwao added p1 preventing everyone from using app bug Something isn't working and removed p2 core functionality, or is affecting 60% of app labels Apr 9, 2023
@yangwao yangwao mentioned this issue Apr 9, 2023
Open
@daiagi daiagi self-assigned this Apr 12, 2023
@kodabot
Copy link
Collaborator

kodabot commented Apr 12, 2023

ASSIGNED - @daiagi 🔒 LOCKED -> Thursday, April 13th 2023, 12:10:35 UTC -> 36 hours

@daiagi daiagi mentioned this issue Apr 12, 2023
Merged
18 tasks
@yangwao yangwao mentioned this issue Apr 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daiagi daiagi

Labels
A-collection work being done collection view A-rmrk2 bug Something isn't working graphql p1 preventing everyone from using app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

⚡️ Activity: lazy load owner insights daiagi/nft-gallery
3 participants
@yangwao @daiagi @kodabot