Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity event improvements #5775

Closed
exezbcz opened this issue Apr 23, 2023 · 1 comment · Fixed by #5801
Closed

Activity event improvements #5775

exezbcz opened this issue Apr 23, 2023 · 1 comment · Fixed by #5801
Assignees
Labels
A-collection work being done collection view p2 core functionality, or is affecting 60% of app UX first Improvement for UX

Comments

@exezbcz
Copy link
Member

exezbcz commented Apr 23, 2023

the events in activity are not consistent enough and sometimes a bit broken in term of layout
addition for:

Mobile and Tablet

image

  • Main change is going to be here
  • events are going to get bigger and will have more space, bigger preview
    image
  • updated in figma - collection detail handoff: https://www.figma.com/file/7BWdGiowrvTucpSFLE0kRX/Collection-detail-handoff?node-id=0%3A1&t=jjaSaxxtfmbYWNc5-1
  • if address from either "from" or "to" is empty, the whole event is removed, like with mint
    image
  • this does not happen with price, if there is not price, -- is there, this will provide some balance
  • preview is now bigger - 70px
  • please make sure the preview is square all the time and check if the preview does not stretch the imgs, but scale them
  • check exact padding in figma please

Changes on desktop

  • overflowing text to second row is an issue
    image
  • text should be cut after a certain length to ensure it does not jump to second row - we can add 3 dots and tooltip on hover - More robust tooltip component for overflowing text  #5704
  • the row could have also better flexible padding between the columns - for example event column has always the same width, so we can maybe lower the margin between price and event etc.

Let's see how this turns out.
Thanks!

@exezbcz exezbcz added UX first Improvement for UX p2 core functionality, or is affecting 60% of app A-collection work being done collection view labels Apr 23, 2023
@Jarsen136 Jarsen136 self-assigned this Apr 24, 2023
@kodabot
Copy link
Collaborator

kodabot commented Apr 24, 2023

ASSIGNED - @Jarsen136 🔒 LOCKED -> Tuesday, April 25th 2023, 21:30:33 UTC -> 36 hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-collection work being done collection view p2 core functionality, or is affecting 60% of app UX first Improvement for UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants