Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polkadot and Kusama NFTs are the same #6494

Closed
JustLuuuu opened this issue Jul 30, 2023 · 7 comments · Fixed by #6748
Closed

Polkadot and Kusama NFTs are the same #6494

JustLuuuu opened this issue Jul 30, 2023 · 7 comments · Fixed by #6748
Labels
A-explorer bug Something isn't working

Comments

@JustLuuuu
Copy link
Member

I'm just curious. This is in production. We have Polkadot NFTs. But they are showing the same NFTs as Kusama NFTs(rmrk). Is that intentional?

Screenshot 2023-07-30 at 10 53 50
@JustLuuuu JustLuuuu added bug Something isn't working A-explorer labels Jul 30, 2023
@yangwao
Copy link
Member

yangwao commented Jul 30, 2023

cc @vikiival

@vikiival
Copy link
Member

Yes this is intentional as i MUST specify the indexer and we agreed with @yangwao back then that it could work as a placeholder.

Other option i can do is spin up dummmy api that would return nothing

@preschian
Copy link
Member

Can we remove polkadot? Since we already had ahk and ahp?

@vikiival
Copy link
Member

vikiival commented Aug 17, 2023

Can we remove polkadot? Since we already had ahk and ahp?

Yes and payouts wont work 😏

Less salty response:
payout bot is tied to /dot/transfer

So if we can preserve that url and remove others I am happy with that

@preschian
Copy link
Member

We can filter that out in here right? we already do that for beta env

export const disableChainListOnBetaEnv = ['movr', 'glmr', 'snek']
export const availablePrefixes = (): Option[] => {
const chains = chainList()
if (isProduction || isBeta) {
return chains.filter(
(chain) => !disableChainListOnBetaEnv.includes(String(chain.value))
)
}
return chains
}

@preschian
Copy link
Member

We can filter that out in here right? we already do that for beta env

The user won't see that in the chain selector but still can access the page directly /dot/transfer

@vikiival
Copy link
Member

Ok let's proceed like that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-explorer bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants