Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLB does not trigger preview upload #680

Closed
obxium opened this issue Sep 2, 2021 · 11 comments
Closed

GLB does not trigger preview upload #680

obxium opened this issue Sep 2, 2021 · 11 comments
Labels
$ ~<50usd bug Something isn't working p1 preventing everyone from using app

Comments

@obxium
Copy link

obxium commented Sep 2, 2021

Describe the bug

I minted an NFT with a GLB media file:

https://nft.kodadot.xyz/rmrk/detail/9050726-34BE282B68C3F03135-FLTS-FRACTAL_LOTUS_1-0000000000000001

The media is not present on any browser that I have access to (most contemporary browsers at latest versions). Instead it looks like this, showing only the KodaDot logo in place of the GLB.

Screen Shot 2021-09-02 at 10 23 30

The file in question, FLOW1.glb is approximately 38MB in size. I have used various tools, such as glTF Validator to ensure that the GLB file content is valid, and it is valid.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://nft.kodadot.xyz/rmrk/mint
  2. Click on the Drop your NFT here or click to upload. We support various media types (BMP, GIF, JPEG, PNG, SVG, TIFF, WEBP, MP4, OGV, QUICKTIME, WEBM, GLB, FLAC, MP3, JSON) uploader
  3. Complete required fields
  4. CLICK TO CREATE NFT(S)

Observe that the finished NFT does not correctly display the GLB model.

Expected behavior

The GLB model content should appear within the figure element for the image-preview div.

Screenshots

Screen Shot 2021-09-02 at 10 23 30

Desktop (please complete the following information):

  • OS: macOS 11.5.2
  • Browser Chrome
  • Version Version 93.0.4577.63 (Official Build)

Additional context

I also tried this on contemporary versions of other Desktop browsers to the same effect.

@obxium obxium added the bug Something isn't working label Sep 2, 2021
@yangwao yangwao added the p2 core functionality, or is affecting 60% of app label Sep 2, 2021
@vikiival
Copy link
Member

vikiival commented Sep 3, 2021

Looks like GLB does not trigger preview upload

Screenshot 2021-09-03 at 11 04 27

Screenshot 2021-09-03 at 11 04 36

@vikiival vikiival changed the title Uploaded GLB asset is not displayed GLB does not trigger preview upload Sep 3, 2021
@vikiival
Copy link
Member

vikiival commented Sep 3, 2021

@obxium :
The trick is that files (like mov, json) trigger additional field called poster/cover
then If this field is visible app automatically constructs JSON like

{
  "image": secondFile,
  "animation_url": file
}

If the preview upload is not triggered app constructs JSON:

{
  "image": file,
}

In GalleryItem.vue I only chceck the mimetype of the secondFile. Thus It fails on render.

But I think we can fix it without re-mint

@obxium
Copy link
Author

obxium commented Sep 7, 2021

Ahh makes sense @vikiival. Thanks for the explanation.

Is is possible then to use the GLB file again as the value to the poster/cover field in order to have it render in gallery view for the next ones I need to mint?

@yangwao
Copy link
Member

yangwao commented Sep 7, 2021

In gallery view, what would be super heavy on objects I guess as GLB objects are quite big, it's an option to have it.
If we can make it make it load on hover or something like that, that might work.
You want to save user bandwidth to not load 12x30MB+ files upfront :)

@obxium
Copy link
Author

obxium commented Sep 7, 2021

In gallery view, what would be super heavy on objects I guess as GLB objects are quite big, it's an option to have it.
If we can make it make it load on hover or something like that, that might work.
You want to save user bandwidth to not load 12x30MB+ files upfront :)

Makes sense, so what do I need to do to have it appear on the actual object page like here:

https://nft.kodadot.xyz/rmrk/detail/5419739-241B8516516F381A-FRACTAL-LOTUS-FRACTAL-LOTUS-1-0000000000000001

Just set the value in animation_url?

@roiLeo
Copy link
Contributor

roiLeo commented Sep 7, 2021

Just set the value in animation_url?

Yes this should work!

@yangwao yangwao added the $ ~<50usd label Sep 24, 2021
@yangwao
Copy link
Member

yangwao commented Sep 24, 2021

So time to solve it, somehow? 😄

@vikiival vikiival added p1 preventing everyone from using app and removed p2 core functionality, or is affecting 60% of app labels Sep 24, 2021
@vikiival vikiival mentioned this issue Sep 24, 2021
@vikiival
Copy link
Member

Screenshot 2021-09-24 at 21 09 34

@yangwao
Copy link
Member

yangwao commented Sep 25, 2021

Closed in #791

@yangwao yangwao closed this as completed Sep 25, 2021
@vikiival vikiival reopened this Sep 25, 2021
@vikiival
Copy link
Member

Need to convince drop upload to spawn another drop upload for the second file

@onerawartist
Copy link

Annotation_2021-11-01_215837.png

I was told on discord to post my report here ^^

@vikiival vikiival mentioned this issue Nov 4, 2021
8 tasks
@yangwao yangwao closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd bug Something isn't working p1 preventing everyone from using app
Projects
None yet
Development

No branches or pull requests

5 participants