Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to enable SubSocial on demand #686

Closed
yangwao opened this issue Sep 3, 2021 · 1 comment
Closed

Ability to enable SubSocial on demand #686

yangwao opened this issue Sep 3, 2021 · 1 comment
Labels
$$ ~51-150usd p2 core functionality, or is affecting 60% of app performance

Comments

@yangwao
Copy link
Member

yangwao commented Sep 3, 2021

We realized that comments put down our bundle before having Nuxt. Adding like 2-3MB right now.
Thus we would like to add user ability to require or show comments if they wish so.
Maybe adding some default switch to Vuex/Settings to make it default off, not showing, best if not loading importantly.
It will save our console log for some infrequent errors coming from Subsocial bundle.
@yangwao yangwao added $$ ~51-150usd p3 non-core, affecting less than 40% performance labels Sep 3, 2021
@yangwao yangwao added p2 core functionality, or is affecting 60% of app and removed p3 non-core, affecting less than 40% labels Sep 16, 2021
@yangwao yangwao mentioned this issue Sep 21, 2021
Open
5 tasks
@roiLeo roiLeo mentioned this issue Nov 23, 2021
Merged
10 tasks
@yangwao
Copy link
Member Author

yangwao commented Apr 14, 2022

We had it removed in #1273 being taking down our app :|

@yangwao yangwao closed this as completed Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$$ ~51-150usd p2 core functionality, or is affecting 60% of app performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yangwao