Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter toggle resets scroll position #8161

Open
exezbcz opened this issue Nov 20, 2023 · 6 comments
Open

Filter toggle resets scroll position #8161

exezbcz opened this issue Nov 20, 2023 · 6 comments
Labels
A-profile related to profile section p3 non-core, affecting less than 40% UX first Improvement for UX

Comments

@exezbcz
Copy link
Member

exezbcz commented Nov 20, 2023

Screen.Recording.2023-11-20.at.20.04.43.mov

it would be nice if that would not happen

afaik it is issue on more places

@prury do you know anything else off the top of your head? 馃憖

@exezbcz exezbcz added UX first Improvement for UX p3 non-core, affecting less than 40% A-profile related to profile section labels Nov 20, 2023
@prury
Copy link
Member

prury commented Nov 20, 2023

Screen.Recording.2023-11-20.at.20.04.43.mov

it would be nice if that would not happen

afaik it is issue on more places

@prury do you know anything else off the top of your head? 馃憖

i think transfer does something similar when clicking on the currencies, but I've always thought it was normal/intended since it forces the user to read which chain they are sending funds to and to make sure they have the proper currency selected

@exezbcz
Copy link
Member Author

exezbcz commented Nov 20, 2023

transfer

yeah that is okay

@prury
Copy link
Member

prury commented Nov 20, 2023

transfer

yeah that is okay

i did a check on canary overall but could not find any place other than profile that the same occurs, for now 馃槃

@exezbcz
Copy link
Member Author

exezbcz commented Nov 20, 2023

@prury thank you sir, appreciate

@exezbcz
Copy link
Member Author

exezbcz commented Dec 2, 2023

anyone? 馃憖

@roiLeo
Copy link
Contributor

roiLeo commented Dec 2, 2023

I think it's happening because we had issue in the past where when you are scolling in page 10 of a collection, add buy filter for example. We had to reset query params and scroll to top to see items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-profile related to profile section p3 non-core, affecting less than 40% UX first Improvement for UX
Projects
None yet
Development

No branches or pull requests

3 participants