Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use css helpers to toggle visiblity #8767

Open
roiLeo opened this issue Dec 27, 2023 · 5 comments
Open

use css helpers to toggle visiblity #8767

roiLeo opened this issue Dec 27, 2023 · 5 comments
Labels
$ ~<50usd css p3 non-core, affecting less than 40%

Comments

@roiLeo
Copy link
Contributor

roiLeo commented Dec 27, 2023 •
edited
Loading 

          maybe use css helpers to toogle visiblity?

Originally posted by @daiagi in #8758 (comment)

replace isMobile and !isMobile in codebase with visibility helper when we can

better to use css than js
@roiLeo roiLeo added p3 non-core, affecting less than 40% css labels Dec 27, 2023
@hassnian hassnian mentioned this issue Dec 27, 2023
Merged
7 tasks
@roiLeo roiLeo changed the title use css helpers to toogle visiblity use css helpers to toggle visiblity Dec 27, 2023
@roiLeo roiLeo mentioned this issue Jan 25, 2024
Merged
7 tasks
@preschian preschian mentioned this issue Jan 27, 2024
Merged
6 tasks
@preschian preschian mentioned this issue Feb 4, 2024
Merged
6 tasks
@roiLeo roiLeo mentioned this issue Feb 4, 2024
Merged
7 tasks
@pbkompasz
Copy link
Contributor

👋

@kodabot
Copy link
Collaborator

kodabot commented Feb 17, 2024

ASSIGNED - @pbkompasz 🔒 LOCKED -> Monday, February 19th 2024, 03:59:19 UTC -> 36 hours

@pbkompasz pbkompasz mentioned this issue Feb 18, 2024
Closed
16 tasks
@preschian preschian mentioned this issue Mar 7, 2024
Merged
4 tasks
@yangwao
Copy link
Member

yangwao commented Mar 21, 2024

Some work was done in

Free to take

@yangwao yangwao added the $ ~<50usd label Mar 21, 2024
@kodabot
Copy link
Collaborator

kodabot commented Mar 21, 2024

ASSIGNMENT EXPIRED - @pbkompasz has been unassigned.

@Haviles04
Copy link
Contributor

I think it might be better to use display properties, unless the directive is a v-show.

v-if = completely removed from dom (display properties)
v-show = still in dom but invisible (visibility properties)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$ ~<50usd css p3 non-core, affecting less than 40%
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use CSS helpers to toggle visiblity pbkompasz/nft-gallery
5 participants
@yangwao @roiLeo @pbkompasz @kodabot @Haviles04