Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uppercase on network indicators #8777

Closed
exezbcz opened this issue Dec 27, 2023 · 3 comments · Fixed by #8778
Closed

uppercase on network indicators #8777

exezbcz opened this issue Dec 27, 2023 · 3 comments · Fixed by #8778
Assignees
@Jarsen136
Labels
A-explorer p3 non-core, affecting less than 40% visual change not affecting ux of app

Comments

@exezbcz
Copy link
Member

exezbcz commented Dec 27, 2023

we should make this unified

  • Lets use Ahp since its used everywhere apart from explore cards

so on explore part, it should be Ahp instead of AHP
@exezbcz exezbcz added p3 non-core, affecting less than 40% A-explorer visual change not affecting ux of app labels Dec 27, 2023
@Jarsen136 Jarsen136 self-assigned this Dec 28, 2023
@kodabot
Copy link
Collaborator

kodabot commented Dec 28, 2023

ASSIGNED - @Jarsen136 🔒 LOCKED -> Friday, December 29th 2023, 14:50:31 UTC -> 36 hours

@Jarsen136 Jarsen136 mentioned this issue Dec 28, 2023
Merged
5 tasks
@roiLeo
Copy link
Contributor

roiLeo commented Dec 28, 2023

#8750 (comment) did you change your mind?

@exezbcz
Copy link
Member Author

exezbcz commented Dec 28, 2023

@roiLeo yeah, saw that on the rest of cards and places its Ahp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jarsen136 Jarsen136

Labels
A-explorer p3 non-core, affecting less than 40% visual change not affecting ux of app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: uppercase on network indicators Jarsen136/nft-gallery
4 participants
@roiLeo @Jarsen136 @exezbcz @kodabot