-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teleport and autoteleport issues on Polkadot <-> Polkadot Assethub #9596
Comments
👋 |
ASSIGNED - @iMac7 🔒 LOCKED -> Friday, March 1st 2024, 17:38:52 UTC -> 24 hours |
+50% of ED wouldn't help? |
|
I think we would need to keep 2 * ED at least So MAX would be = totalBalance - 2 * ED |
How about for autoteleport, check if the amount to be teleported in > 2 * ED ? |
@kodadot/internal issue open for taking |
ASSIGNMENT EXPIRED - @iMac7 has been unassigned. |
We have checked delivery fees and found following information: Polkadot delivery fee: 0.047DOT We are unable to confirm if these values are 100% correct so needs further testing. |
so, another user reported he lost funds, @prury will confirm if its correct. Probably let's raise the ed as teleporting from Polkadot to ahp is quite crucial for us ad autoteleport Are there any other solutions? |
yup, correct: |
We would suggest to leave at least 1.5 dot (Not 1.5-fees but entire 1.5) on chain to ensure, that user won't loose funds.
AFAIK only one mentioned above until PolkadotJS fixes accounting for delivery fee and until Parity introduces ClaimAsset() function to recover fees. We will be implementing it in ParaSpell asap after it will be introduced: paraspell/xcm-tools#181 You will then be able to implement it to teleport for users that lost funds. With proper guide on recovering them there will be no more teleport issues further on we hope. Oh and also when that delivery fee issue is fixed. With kind regards, |
ASSIGNED ISSUES LIMIT REACHED - @Jarsen136, you have been already assigned with 5 issues: 4042,5941,7217,8901,9046,9716,9727. Finish one of them in order to get more issues assigned! |
It probably does not work guys
can you have a look, please? People should not be losing funds |
We have checked call formatting and it seems to be correct. What we also found out is, that user sent entire funds they had from Polkadot -> AssetHubPolkadot. This was 1.03 DOT. Not sure how they managed to do this however. Wasn't the minimal deposit limit raised to 1.5 DOT? |
it happened on the autoteleport, maybe something is needed to do there as well? thanks for the information @dudo50 ! |
can anyone have a look please? @kodadot/internal-dev |
@exezbcz tried with two testing accounts i have: Account 1: (same funds as user 1,03 DOT on Polkadot) Account 2: (A bit more than user, around 1.1) On both cases, i was unable to auto-teleport when trying to change price, list, buy and other interactions, only the add funds via onramp shows to me. The only possibility that i think would be user going to teleport page and ignoring all the warnings and teleporting the full amount(still possible by ignoring the warnings) |
Ah wasnt that caused by doubling the ED by @Jarsen136 ? |
Yes, it's as expected because we have increased the ED.
It's possible |
i think the user that lost funds used autoteleport - there is no warning - if there will be fundloss, it should not be enabled so question, from what amount is the user okay if he wants to mint 1 nft from 0.5 DOT price drop? Transferring dot from polkadot to ahp it crucial if there will be a bigger traffic - people not always have 2 dot just to mint 0.5 dot drop |
so logical option would be - if you have like 1.2 DOT and wanna teleport 0.5 DOT, |
@vikiival that is how it was before afaik. If person have other assets on polkadot relay, that would delete that no? |
no. it would teleport all of it to AssetHub, avoiding unexpected loss of funds |
@vikiival that would not work due to delivery fee. If you send all your tokens, delivery fee is not accounted for and thus it will trap the assets. The only option for now is for user to have at least 1.5DOT on Polkadot and only transfer sum they have above 1.5 DOT -> eg. User has 2.8 DOT. That means they are able to safely transfer 1.3 DOT (Until the bug with delivery fee is fixed). |
Maybe upcoming runtime update to 1.1.3 will fix this issue but I doubt that because description of it is, to fix staking pallet from bricking. |
@dudo50 hello, what can we do to move it forward? I can name at least 8 users that lost funds would creating issue help? another one: |
@exezbcz I've checked SDK and call format, once again, SDK works as expected. The issue is, that the user somehow teleported 1.5 dot when they only had 2+ dot probably leaving them with less than deposit minimum leading to slash of account and asset trap and loss. The Kodadot devs should not allow users to teleport if they won't have at least 1.5 DOT on Polkadot after teleport happens. That way everything should work as expected. After Parity introduces claimAsset function to Runtime we will implement it to the SDK and give you guide on implementing it. For now this is only advice I can give you: Either do not allow them to go below 1.5 Dot on Polkadot or disable teleporting until PolkadotJS fixes delivery fee accounting. With kind regards, |
The same bug that happened on Kusama in the last month(XCM related) is also happening on Polkadot where users lose funds when trying to teleport an amount near ED.
let's disable teleport and autoteleport until there's a fix from parity
The text was updated successfully, but these errors were encountered: