Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-render svg for og social cards #973

Closed
yangwao opened this issue Oct 31, 2021 · 6 comments
Closed

pre-render svg for og social cards #973

yangwao opened this issue Oct 31, 2021 · 6 comments
Labels
$ ~<50usd A-research we will research on these p3 non-core, affecting less than 40%

Comments

@yangwao
Copy link
Member

yangwao commented Oct 31, 2021

Right now when you check animated SVG you don't get a preview for social cards which is pitty.

ideation would be set serverless function which would fetch very last frame, 95%? from NFT and show it?

@yangwao yangwao added A-research we will research on these p3 non-core, affecting less than 40% labels Oct 31, 2021
@yangwao
Copy link
Member Author

yangwao commented Oct 31, 2021

Maybe @AndriiHrynchuk can chek on this 👀

@AndriiHrynchuk
Copy link
Contributor

on it. I remember we used to have separate field for preview images. Currently I see that preview for 3D NFTs not shown as well. Are there are any changes made to metas?

@yangwao yangwao added $ ~<50usd p2 core functionality, or is affecting 60% of app and removed p3 non-core, affecting less than 40% labels Nov 14, 2021
@yangwao
Copy link
Member Author

yangwao commented Nov 14, 2021

I recall for 3D this was added recently we can use for 3D #1022

SVG is quite different, probably I would target 2/3 frame from the total length. or let's aim at 75%th frame?
As some stuff fade out

Test suite

Deepologic has tons of them in various collections
https://kodadot.xyz/rmrk/u/FqCJeGcPidYSsvvmT17fHVaYdE2nXMYgPsBn3CP9gugvZR5?tab=collection

@AndreyGrin
Copy link
Member

got it working on free account but there are memory limit exists so animation can play max around 6 seconds. Paid plan can handle longer animations.

@AndreyGrin
Copy link
Member

deployed to Vercel. One small thing is required to add from Kodadot as well, will make PR

@yangwao yangwao added p3 non-core, affecting less than 40% and removed p2 core functionality, or is affecting 60% of app labels Jan 24, 2023
@roiLeo
Copy link
Contributor

roiLeo commented Nov 23, 2023

@roiLeo roiLeo closed this as completed Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd A-research we will research on these p3 non-core, affecting less than 40%
Projects
None yet
Development

No branches or pull requests

4 participants