Going back on browser shows past variation

[exezbcz]

Screen.Recording.2024-03-21.at.13.31.16.mov

this was not happening before, you should get to the page that you were before

how to reproduce: generate few variations and click back

[kodabot]

ASSIGNED - @Jarsen136 🔒 LOCKED -> Saturday, March 23rd 2024, 24:37:39 UTC -> 36 hours

[Jarsen136]

I do not have an ideal solution as it's more of browser behaviour.

[kodabot]

ASSIGNMENT OVER - @Jarsen136 has been unassigned.

[exezbcz]

@Jarsen136 and did it happen before? Because i think previously the back button was working as expected

[daiagi]

this is strange
it is definitely this line

nft-gallery/components/collection/drop/GenerativePreview.vue

Line 132 in 7b003c6

generativeImageUrl.value = previewItem.image

but since when does setting a value to a ref pushes into history?

also, no affect on url or on history API

https://developer.mozilla.org/en-US/docs/Web/API/History_API

[Jarsen136]

@Jarsen136 and did it happen before? Because i think previously the back button was working as expected

Yes, it's the same as before. It's related to the iframe would effect the browser history.

Here is the preview env from two months ago. https://deploy-preview-9343--koda-beta.netlify.app/ahp/drops/convergente

[daiagi]

@Jarsen136

am i blind? i don't find an Iframe in the page

[Jarsen136]

@Jarsen136

am i blind? i don't find an Iframe in the page

search the iframe element in HTML

[daiagi]

weird. it's an image on localhost and iframe on production

[daiagi]

where is the sandbox attribute determined?

didn't see anything about it in MediaItem.vue

maybe can use this?

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#allow-top-navigation

[Jarsen136]

weird. it's an image on localhost and iframe on production

it should be the same as localhost.

where is the sandbox attribute determined?

didn't see anything about it in MediaItem.vue

IFrameMedia.vue

maybe can use this?

Feel free to delve deeper and give it a shot

[daiagi]

doesn't work
i removed all permissions

didn't do a thing

[daiagi]

i'll try something else

[kodabot]

ASSIGNED - @daiagi 🔒 LOCKED -> Sunday, March 24th 2024, 22:02:19 UTC -> 36 hours