Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current layout display on Collection & Profile #986

Closed
roiLeo opened this issue Nov 1, 2021 · 4 comments
Closed

Current layout display on Collection & Profile #986

roiLeo opened this issue Nov 1, 2021 · 4 comments
Labels
$ ~<50usd bug Something isn't working p3 non-core, affecting less than 40%

Comments

@roiLeo
Copy link
Contributor

roiLeo commented Nov 1, 2021 •
edited
Loading

Describe the bug
On collection page, the current layout button is not active

To Reproduce
Steps to reproduce the behavior:

  1. Go to any collecion id
  2. See current layout display

Expected behavior
When on collection, activate button with current display

Screenshots

Current

Capture d’écran 2021-11-01 à 2 16 18 PM

Excepted

Capture d’écran 2021-11-01 à 2 16 49 PM

Additional context
We need to create a <ToggleLayout /> component for #967
@roiLeo roiLeo added the bug Something isn't working label Nov 1, 2021
@yangwao yangwao added $ ~<50usd p3 non-core, affecting less than 40% labels Nov 2, 2021
@roiLeo roiLeo mentioned this issue Nov 2, 2021
Merged
4 tasks
@prachi00
Copy link
Member

prachi00 commented Nov 2, 2021

@roiLeo is this still an issue? as I don't see it happening anymore.

@roiLeo
Copy link
Contributor Author

roiLeo commented Nov 2, 2021

@roiLeo is this still an issue? as I don't see it happening anymore.

merged in #1003 but we still need a ToggleLayout component

@prachi00
Copy link
Member

prachi00 commented Nov 2, 2021

@roiLeo is this still an issue? as I don't see it happening anymore.

merged in #1003 but we still need a ToggleLayout component

Sure, will pick that up then

@roiLeo roiLeo mentioned this issue Nov 4, 2021
Merged
6 tasks
@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 29, 2021

closed by @prachi00 if I'm right but can't find the linked PR

@roiLeo roiLeo closed this as completed Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$ ~<50usd bug Something isn't working p3 non-core, affecting less than 40%
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yangwao @roiLeo @prachi00