Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle BUY logically #11

Open
vikiival opened this issue Apr 4, 2022 · 0 comments
Open

Handle BUY logically #11

vikiival opened this issue Apr 4, 2022 · 0 comments

Comments

@vikiival
Copy link
Member

vikiival commented Apr 4, 2022

https://github.com/galacticcouncil/Basilisk-node/pull/137/files#diff-9d33539ccde27d65f6015df1d5ece6b353c7a20c99d6f95220f16a7f981e823dR419-R421

That means We emit transfer and then emit buy

Buy should set price to zero and add buy event
however It will skew the metric because no transfer has happened

possilibity is to:

  • check if there is buy event within the block
  • handle transfer and sell by the same handler :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant