Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offers #9

Closed
vikiival opened this issue Mar 29, 2022 · 0 comments 路 Fixed by #25
Closed

Offers #9

vikiival opened this issue Mar 29, 2022 · 0 comments 路 Fixed by #25
Milestone
001

Comments

@vikiival
Copy link
Member

vikiival commented Mar 29, 2022 •
edited
Loading

Basically there is a ton of edge cases.

but the most crucial ones:

  • what to do with withdrawn offer? (remove or just update?)
  • what to do on accept offer? (// may status to accepted to true 馃し )
  • add current_owner to offers? (if not removed could be nice for analytics)

ref galacticcouncil/Basilisk-node#424
@vikiival vikiival added this to the 001 milestone Mar 29, 2022
@vikiival vikiival mentioned this issue Apr 4, 2022
Closed
89 tasks
@vikiival vikiival linked a pull request May 31, 2022 that will close this issue
grind snek #25
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
001
Development

Successfully merging a pull request may close this issue.

grind snek kodadot/snek
1 participant
@vikiival