Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlashDevelop classpaths --from --to problem #23

Closed
sh-dave opened this issue Dec 17, 2015 · 1 comment
Closed

FlashDevelop classpaths --from --to problem #23

sh-dave opened this issue Dec 17, 2015 · 1 comment

Comments

@sh-dave
Copy link
Contributor

sh-dave commented Dec 17, 2015

Hi Robert,

i just tried to use the --from --to flags while creating a project.

@node Kha/make --target flash --from src/spriter/example-kha-g2 --to build/example-kha-g2

results in Kha paths being broken.

<class path="..\..\src\spriter\example-kha-g2\e:\projects.libraries\Spriter-Example\Kha\Sources" />
<class path="..\..\src\spriter\example-kha-g2\e:\projects.libraries\Spriter-Example\Kha\Backends\Flash" />
<class path="..\..\src\spriter\example-kha-g2" />
<class path="..\..\SpriterHaxeEngine" />

Bugfix is quite easy: In khamake/HaxeProject.js change path.join() to path.resolve()

    for (let i = 0; i < options.sources.length; ++i) {
        classpaths.e.push({
            n: 'class',
            path: path.relative(projectdir, path.resolve(options.from, options.sources[i]))
            //path: path.relative(projectdir, path.join(options.from, options.sources[i]))
        });
    }

Result:

<class path="..\..\Kha\Sources" />
<class path="..\..\Kha\Backends\Flash" />
<class path="..\..\src\spriter\example-kha-g2" />
<class path="..\..\SpriterHaxeEngine" />

Now i think i should start to learn how to do proper forks and pull requests and stuff instead of posting here 😅

@RobDangerous
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants