Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should return non-success error code on compilation failure #257

Closed
anissen opened this issue Feb 28, 2022 · 0 comments
Closed

Should return non-success error code on compilation failure #257

anissen opened this issue Feb 28, 2022 · 0 comments

Comments

@anissen
Copy link

anissen commented Feb 28, 2022

Only returning a successful error code on a success compilation will make it easier to chain together scripts.

For example, running this:

node Kha/make --debug --compile --graphics metal --quiet && echo "Success!"

Will result in this output:

** BUILD FAILED **


The following build commands failed:
	CompileC /Users/anders/projects/cosy-breakout/build/osx-build/build/Crafty.build/Debug/Crafty.build/Objects-normal/arm64/VorbisDecodeState.o /Users/anders/projects/cosy-breakout/build/osx-build/Sources/src/kha/audio2/ogg/vorbis/VorbisDecodeState.cpp normal arm64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'Crafty' from project 'Crafty')
(1 failure)
Compilation failed.
undefined
Success!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant