Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVR channels widget doesn't pass other artwork types (e.g. poster / fanart). #20

Closed
jurialmunkey opened this issue Sep 17, 2017 · 5 comments

Comments

@jurialmunkey
Copy link

Had a few reports that PVR channels widgets are only passing through the thumb image that is defined in managed artwork. I checked and it seems that even if posters / fanart etc are manually defined inside the MyPVR* windows the widgets do not fill ListItem.Art(poster) or ListItem.Art(fanart) etc.

Are these possible to add?

@marcelveldt
Copy link
Contributor

Did you notice that in the settings for this add-on you can enable the artwork lookups ?

@jurialmunkey
Copy link
Author

I had it enabled when I was testing.
Using the Demo PVR add-on, I set an item manually inside TVChannels window. The artwork displays correctly there. In the widget, the background fanart using the Skin Helper window property will show correctly for the item so it is being looked up, but inside the container ListItem.Art(fanart) is blank. Are the listitem properties only filled by automatic look-ups and not manually set ones?

@dazedcrazy
Copy link

It gets all the correct images
vflxkw7
But only displays the thumb
wnn91cz
No matter the widget type
hlqydma
xcghued

@dazedcrazy
Copy link

This is where it makes things look really stupid when it uses the thumb instead of the poster
Images it gets
lptlrtg
And image it uses
wyskd71

@natevoci
Copy link

natevoci commented Dec 19, 2017

Hi @jurialmunkey

I've noticed in the code that the poster and fanart art do get set from the get_pvr_artwork call (if "Enable artwork lookups for PVR" setting is on). The relevent code is in %appdata/Kodi/addons/script.skin.helper.widgets/resources/lib/pvr.py in the process_channel function,

            if self.enable_artwork:
                self.metadatautils.extend_dict(
                    item, self.metadatautils.get_pvr_artwork(
                        item["title"], channelname, item["genre"]))

but it then the art property gets replaced later in that function

        if channellogo:
            item["art"] = {"thumb": channellogo}

Perhaps try changing it so that it uses the existing art object if it exists, and only sets the thumb property if it's missing. Something like this (untested)

        if channellogo:
            if not item.get("art"):
                item["art"] = {}
            if not item["art"].get("thumb"):
                item["art"]["thumb"] = channellogo

Edit: Fixed a missing : in the code snippet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants