Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: re(this new behaviour expected?) #63

Closed
mgonzales71 opened this issue May 14, 2015 · 19 comments
Closed

update: re(this new behaviour expected?) #63

mgonzales71 opened this issue May 14, 2015 · 19 comments

Comments

@mgonzales71
Copy link
Collaborator

2015-05-14_00-43-33

@mgonzales71 mgonzales71 changed the title this new behaviour expected? buttonfocuscolor this new behaviour expected? May 14, 2015
@mgonzales71
Copy link
Collaborator Author

2015-05-14_00-53-42

@mgonzales71
Copy link
Collaborator Author

2015-05-14_00-56-42

@marcelveldt
Copy link
Contributor

Hi Mario, thanks for noticing!
Will fix it tomorrow

@mgonzales71 mgonzales71 changed the title this new behaviour expected? update: re(this new behaviour expected?) May 15, 2015
@mgonzales71
Copy link
Collaborator Author

oops! ;)

new cosmetic issues with list, overlays, etc - no rush sir! - just FYI

2015-05-15_13-05-16

@mgonzales71
Copy link
Collaborator Author

oh - btw - I liked the updated fonts - right now you have a mixture of ubuntu and old roboto - what didn't look right to you with the new fonts?

I did notice a couple of double font name entries looking over the existing font sets - i will look at the entire list this weekend and see if I can clean up and remove the entries at the very least :)

one i noticed at first glance was this double entry:

    <font>
        <name>Reg28</name>
        <filename>Regular.ttf</filename>
        <size>28</size>
    </font>

    <font>
        <name>Reg28</name>
        <!--Small-->
        <filename>Regular.ttf</filename>
        <size>32</size>
    </font>

@mgonzales71
Copy link
Collaborator Author

also noticed unfocused list item (A) is not same height as focused list item (B) if that matters:

2015-05-15_13-18-20

@marcelveldt
Copy link
Contributor

Hi Mario,

fixed the issue with the overlays in biglist/lowlist, thanks for noticing.

As for the different line height in the normal list: that has Always been like that, it's on purpose because the focused item shows the info while the unfocused item doesn't.

The fonts are indeed different. I did that back then to create a difference between light, regular and bold. I have no problem in updating the font as long as the main regular font stays as close to what it is now. Also keep in mind that only limited fonts are considered fully opensource and can be redistributed with the skin.

So, it's not that I didn't like your update with the font but it needs to be reviewed. A lot of text just got way too big when I tested it so I did a quick revert of the font files only. It's okay to update the fonts, in fact the "light" font can be improved but it must stay as close to what it is now because the current font suits the skin and all sizes are adjusted for the used font. If the new font differs in size it's a hell of a job to get everything adjusted to that. You have to check every single screen/view in the skin if all content still fits. Both with normal font-setting and with the "large" option.

If you have some spare time and are willing to review every part of the skin to make the change be my guest ;-)

@mgonzales71
Copy link
Collaborator Author

I will work more on fonts this weekend for you. I may actually create a new font set for testing and on-going adjustments until all views can be checked out.

@marcelveldt
Copy link
Contributor

that would be really great!!!

@marcelveldt
Copy link
Contributor

btw: what do you think of my adjustments to the list views today ?

@mgonzales71
Copy link
Collaborator Author

looks good - did you get any screams from the beta users on the forum? i haven't read any posts yet today,

@marcelveldt
Copy link
Contributor

My attempt from yesterday did get some negative attention, it was the wrong direction. Today I worked a bit more on it and now it looks much better. Also confirmed on the forum :-)

@mgonzales71
Copy link
Collaborator Author

hehe - yea I was shocked at the change in direction myself - the rounded corners mostly since I thought you wanted more square/sharp edges. I like the updated look over yesterdays so right direction - funny how it's the little touches/changes that can be the most noticed and get the most feedback from folks :)

@marcelveldt
Copy link
Contributor

I left the rounded corners in... Still haven't decided yet if I leave it in or not. Untill now I think it's a little touch that makes it perfect. The skin is still square/sharp edged but just a little rounding on the corners. For now I think I like it :-)

@mgonzales71
Copy link
Collaborator Author

personally I like the slight rounded edges - so no real complaints there. makes things more organic - a good mixture of both works - just keep a balance I suppose and make sure it looks nice in the end!

at some point you may want to consider adding:

a "provide feedback" button in the skin settings
and an opt-in for anonymous skin usage statistics (on skin's first run?)

could help better understand the usage, demographics, hardware, etc

@marcelveldt
Copy link
Contributor

hehe, glad we agree on that :-)
I think it will stay this way. The skin looks more finished now.
Now getting that appearance settings stuff perfect.. will be a hell of a job to do but once finished it's amazing I think.

Good idea about the opt-in, something for on the "to do" list :-)

@mgonzales71
Copy link
Collaborator Author

low list still has tiny cosmetic issues

i would suggest watched overlay on right side of list items maybe? having the watched overlays on the left in any of the lists feels strange actually but that is just me and the newness of it all still,

but i would move it to the right LOL hehe ;-)

screenshot000

@mgonzales71
Copy link
Collaborator Author

oh fun fun fun - one more in addition to above ;-)

ratings / stars music OSD

screenshot004

@marcelveldt
Copy link
Contributor

forgot to update on this: all fixed in recent builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants