Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui bump missing #141

Closed
MartijnKaijser opened this issue Dec 8, 2015 · 4 comments
Closed

Gui bump missing #141

MartijnKaijser opened this issue Dec 8, 2015 · 4 comments

Comments

@MartijnKaijser
Copy link
Member

No description provided.

@ksooo
Copy link
Member

ksooo commented Dec 8, 2015

Not hundred percent sure, but I think a simple recompile of pvr.hts (and all other addons not having explicit tag in addon.xm.in) will do the trick. At least that fixed the incompatbilty for me. And as there was a transifex update including addon version bump yesterday this will even be fixed without any further action.

@MilhouseVH
Copy link

And as there was a transifex update including addon version bump yesterday this will even be fixed without any further action.

Yep, this now seems to be fixed (forum post). Kinda feels a bit random, though - shouldn't the add-on be explicit about the version of kodi.guilib it requires?

@ksooo
Copy link
Member

ksooo commented Dec 9, 2015

TBH, I don't get how this is supposed to work.

On the one hand, the version can be defined in addon.xml.in, on the other hand it must be (hard)coded into addon functions like GetGUIAPIVersion.

pvr.hts does not even depend on kodi.guilib, therefore not putting a dependency into addon.xml.in seems okay, but according to 254b4e2, one must supply an implementation for GetGUIAPIVersion and the docs do not specify a "no guilib needed" return value...

@MartijnKaijser
Copy link
Member Author

confusing......

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants