Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about debugging? #17

Open
erykpiast opened this issue Aug 9, 2015 · 7 comments
Open

What about debugging? #17

erykpiast opened this issue Aug 9, 2015 · 7 comments

Comments

@erykpiast
Copy link

The project seems super-interesting, I can't wait to try! But one question came to my mind - what about debugging? Did you consider sourcemaps generation? Or conditional (process.env.NODE_ENV !== 'production) expanding class names to readable form (like _xy132as_redButton). Do you plan anything like that?

@donaldpipowitch
Copy link

Source map support would be great. I think I wouldn't use stilr without Source maps.

@danieljuhl
Copy link
Contributor

PR is very welcome. We will look into this, but I can't see exactly when, so any PR could speed up the process.

@aulizko
Copy link

aulizko commented Sep 14, 2015

PostCSS can create sourcemap.

I think this will be enough. It'll generate inline source map, which is fast and therefore completely OK for development IMO.

if (process.env !== 'production') {
  const prefixedCSS = postcss(autoprefixer())
    .process( StyleSheet.render(), { map: true} ) // <--- THIS
    .css;
  stylesheet.textContent = prefixedCSS;
}

As for production usage, you can generate separate source map, too. See the docs.

@boyswan
Copy link

boyswan commented Oct 8, 2015

would be great to expand on classnames, only problem I have with Stilr is hash only classnames!

@danieljuhl
Copy link
Contributor

@boyswan sorry, but I do not understand, what you want. Can you please rephrase? You would like Stilr to not use hashes as classnames?

@boyswan
Copy link

boyswan commented Oct 8, 2015

At the moment classnames are generated as pure hashe's i.e. 'xy132as', it would be great if we could also include the actual classname, i.e. 'button_xy132as'

@danieljuhl
Copy link
Contributor

Okay, so actually just a vote for the initial issue comment? PR is more than welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants