Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recently Played must be obtained from the database. Not from browser local storage. #736

Closed
matiasdelellis opened this issue Apr 6, 2018 · 1 comment · Fixed by #839
Closed

Comments

@matiasdelellis
Copy link

Hey, thanks for contributing to Koel! To save time for both of us, please make sure these checkboxes are checked before submitting the issue:

  • [ x] You have read and followed closely the Wiki, Upgrade Guide, as well as Troubleshooting
  • [ x] The issue has not been reported before
  • [ x] This is not a "how to install on Windows" or "why is my npm messed up" question
  • [ x] You're a cool person

All checked? Now also make sure your issue

  • [ ]x Is associated with a version. Or better yet, a commit.
  • [ x] Is as detailed as possible (ahem... OS, browser, steps to reproduce, maybe?)
  • [ x] Includes the error output if it's a bug/error report ("Whoops!" is not very helpful, you know)
  • [ x] Is in English, 因为我不说中文。

Bug Report

The list of recently played songs only shows those played in current browser. The information is stored in local storage of browser.
If I play songs on the work computer, and then on my notebook I want to have a reference of the last played to continue reproducing, but instead, I have the last thing that play a week ago using this computer. 😞

@phanan
Copy link
Member

phanan commented Apr 9, 2018

Yes, "recently played" are saved in local storage for the sake of simplicity, but I intend to implement a server-side solution eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants