Skip to content

Commit

Permalink
Fix z position bug, thanks Fran
Browse files Browse the repository at this point in the history
  • Loading branch information
koenbok committed Jun 8, 2015
1 parent 6bb2038 commit f08d7f6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
3 changes: 1 addition & 2 deletions framer/LayerStyle.coffee
Expand Up @@ -81,7 +81,6 @@ exports.LayerStyle =


webkitTransform: (layer) -> webkitTransform: (layer) ->



# We have a special rendering path for layers that prefer 2d rendering. # We have a special rendering path for layers that prefer 2d rendering.
# This definitely decreases performance, but is handy in complex drawing # This definitely decreases performance, but is handy in complex drawing
# scenarios with rounded corners and shadows where gpu drawing gets weird # scenarios with rounded corners and shadows where gpu drawing gets weird
Expand All @@ -91,7 +90,6 @@ exports.LayerStyle =
return exports.LayerStyle.webkitTransformForce2d(layer) return exports.LayerStyle.webkitTransformForce2d(layer)


" "
translate3d(#{layer._properties.x}px,#{layer._properties.y}px,#{layer._properties.z}px)
scale(#{layer._properties.scale}) scale(#{layer._properties.scale})
scale3d(#{layer._properties.scaleX},#{layer._properties.scaleY},#{layer._properties.scaleZ}) scale3d(#{layer._properties.scaleX},#{layer._properties.scaleY},#{layer._properties.scaleZ})
skew(#{layer._properties.skew}deg,#{layer._properties.skew}deg) skew(#{layer._properties.skew}deg,#{layer._properties.skew}deg)
Expand All @@ -100,6 +98,7 @@ exports.LayerStyle =
rotateX(#{layer._properties.rotationX}deg) rotateX(#{layer._properties.rotationX}deg)
rotateY(#{layer._properties.rotationY}deg) rotateY(#{layer._properties.rotationY}deg)
rotateZ(#{layer._properties.rotationZ}deg) rotateZ(#{layer._properties.rotationZ}deg)
translate3d(#{layer._properties.x}px,#{layer._properties.y}px,#{layer._properties.z}px)
" "


webkitTransformForce2d: (layer) -> webkitTransformForce2d: (layer) ->
Expand Down
6 changes: 3 additions & 3 deletions test/tests/LayerTest.coffee
Expand Up @@ -84,7 +84,7 @@ describe "Layer", ->
layer.y.should.equal 50 layer.y.should.equal 50


# layer.style.webkitTransform.should.equal "matrix(1, 0, 0, 1, 100, 0)" # layer.style.webkitTransform.should.equal "matrix(1, 0, 0, 1, 100, 0)"
layer.style.webkitTransform.should.equal "translate3d(100px, 50px, 0px) scale(1) scale3d(1, 1, 1) skew(0deg, 0deg) skewX(0deg) skewY(0deg) rotateX(0deg) rotateY(0deg) rotateZ(0deg)" layer.style.webkitTransform.should.equal "scale(1) scale3d(1, 1, 1) skew(0deg, 0deg) skewX(0deg) skewY(0deg) rotateX(0deg) rotateY(0deg) rotateZ(0deg) translate3d(100px, 50px, 0px)"


it "should set scale", -> it "should set scale", ->


Expand All @@ -95,7 +95,7 @@ describe "Layer", ->
layer.scaleZ = 100 layer.scaleZ = 100


# layer.style.webkitTransform.should.equal "matrix(1, 0, 0, 1, 100, 50)" # layer.style.webkitTransform.should.equal "matrix(1, 0, 0, 1, 100, 50)"
layer.style.webkitTransform.should.equal "translate3d(0px, 0px, 0px) scale(1) scale3d(100, 100, 100) skew(0deg, 0deg) skewX(0deg) skewY(0deg) rotateX(0deg) rotateY(0deg) rotateZ(0deg)" layer.style.webkitTransform.should.equal "scale(1) scale3d(100, 100, 100) skew(0deg, 0deg) skewX(0deg) skewY(0deg) rotateX(0deg) rotateY(0deg) rotateZ(0deg) translate3d(0px, 0px, 0px)"


it "should set origin", -> it "should set origin", ->


Expand Down Expand Up @@ -875,7 +875,7 @@ describe "Layer", ->


layer = new Layer layer = new Layer


layer.style.webkitTransform.should.equal "translate3d(0px, 0px, 0px) scale(1) scale3d(1, 1, 1) skew(0deg, 0deg) skewX(0deg) skewY(0deg) rotateX(0deg) rotateY(0deg) rotateZ(0deg)" layer.style.webkitTransform.should.equal "scale(1) scale3d(1, 1, 1) skew(0deg, 0deg) skewX(0deg) skewY(0deg) rotateX(0deg) rotateY(0deg) rotateZ(0deg) translate3d(0px, 0px, 0px)"


layer.force2d = true layer.force2d = true


Expand Down

0 comments on commit f08d7f6

Please sign in to comment.