Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to npm? #71

Open
paulyoung opened this issue May 17, 2014 · 16 comments
Open

Publish to npm? #71

paulyoung opened this issue May 17, 2014 · 16 comments

Comments

@paulyoung
Copy link

I'd like to create something that depends on Framer.

@koenbok
Copy link
Owner

koenbok commented May 17, 2014

Sure. I don't see why not :-)

@koenbok
Copy link
Owner

koenbok commented May 17, 2014

Here you go:

https://www.npmjs.org/package/framerjs

@koenbok koenbok closed this as completed May 17, 2014
@paulyoung
Copy link
Author

👍

@paulyoung
Copy link
Author

When I require('framerjs') I get Error: Cannot find module 'framerjs'.

@paulyoung
Copy link
Author

So, this is due to the build directory not being submitted as part of the package.

@koenbok - could you make that happen?

@paulyoung
Copy link
Author

Actually, Bower might be better for this. At least having a component.json file would let me try that out.

@paulyoung
Copy link
Author

@koenbok - wondering if you'd mind following up here.

paulyoung added a commit to paulyoung/Framer that referenced this issue Jun 11, 2014
@zanona
Copy link

zanona commented Aug 5, 2015

As of v3.0.0 the build/frame.js file is not included making it impossible to depend on the framejs via npm? Perhaps this issue should be re-opened?

@jchavarri
Copy link
Contributor

@zanona @paulyoung You can build automatically after installing, using the scripts key on your package.json:

"scripts": { "postinstall": "cd ./node_modules/framerjs && make" }

@jacobbubu
Copy link

I think this issue should be reopen due to the lack of compiled version of framerjs,

@koenbok
Copy link
Owner

koenbok commented Dec 15, 2015

I keep them here: http://builds.framerjs.com/

But I don't like keeping them in git because you get huge nonsensical diffs.

@jacobbubu
Copy link

You don't need to put the compiled version into git like you did already (add build file in .gitignore).
Just add { “republish”: ‘make’ } to scripts field in ‘package.json’ and change the main filed to ./build/framer.js. And then I also recommend that moving most of the dependencies that used for build and test into ‘devDependencies’. That makes more npm friendly and save a lot of for npm install.

@koenbok koenbok reopened this Dec 15, 2015
@koenbok
Copy link
Owner

koenbok commented Dec 15, 2015

Ok let's do it.

@paulyoung
Copy link
Author

For my own projects, I've followed similar steps to those outlined here: http://mammal.io/articles/using-es6-today/#publishing-to-npm

@jperals
Copy link

jperals commented Aug 14, 2017

Hi there, any update about this? @jacobbubu's proposal seems quite straightforward to implement (with the required change that the republish task should be "make release" instead of just "make", I think). I could provide a PR myself —unless now there is any reason against doing this @koenbok? (I guess not as this issue is still open)

PS: actually, the main field in package.json points to lib/Framer.js which doesn't exist, even after building? That doesn't make sense anyway, right?, or am I missing something?

@eelco
Copy link
Collaborator

eelco commented Aug 17, 2017

Hey @jperals, Framer doesn’t have semantic versioning, which makes it not so nice to work with in combination with npm. It’s (therefore?) not a popular use case either, making this issue very low priority. The main field is indeed outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants
@eelco @zanona @paulyoung @koenbok @jchavarri @jacobbubu @jperals and others