Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zigbee-herdsman:zStack:unpi:parser throwing binary debug messages #76

Closed
lolorc opened this issue Oct 17, 2019 · 4 comments
Closed

zigbee-herdsman:zStack:unpi:parser throwing binary debug messages #76

lolorc opened this issue Oct 17, 2019 · 4 comments
Labels

Comments

@lolorc
Copy link

lolorc commented Oct 17, 2019

Looks like it logs unformatted binary data:
https://github.com/Koenkk/zigbee-herdsman/blob/master/src/adapter/z-stack/unpi/parser.ts#L45

@Koenkk
Copy link
Owner

Koenkk commented Oct 17, 2019

At the point this data is still binary, what's wrong with it?

@lolorc
Copy link
Author

lolorc commented Oct 17, 2019

having binary data in a log is useless as most of it is unprintable; and my terminal keeps beeping (visual beep here) all the time.
(yep I'm running with DEBUG=* all the time)
but it's definitely not a major issue but it's annoying. I've quickly tried a toJSON(), I failed :) I'm not even sure what kind of object frame is.

@Koenkk
Copy link
Owner

Koenkk commented Oct 17, 2019

Running with DEBUG=zigbee-herdsman:controller* probably makes more sense. The layers below are actually already well tested (they are in zigbee2mqtt 1.6.0)

@stale
Copy link

stale bot commented Dec 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 16, 2019
@stale stale bot closed this as completed Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants