Skip to content
This repository has been archived by the owner on Feb 2, 2020. It is now read-only.

New feature: Repeat last task #2

Closed
philipp2310 opened this issue Jan 14, 2019 · 2 comments
Closed

New feature: Repeat last task #2

philipp2310 opened this issue Jan 14, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@philipp2310
Copy link
Contributor

From Discord:

eto today at 23:07 Uhr
another question: is it possible to restart the last action? "repeat" "again"
exmple : "Please give me more light in the living room" and "again" it's possible ?

I think it is a good idea and would be willing to implement it in the next few weeks. (currently busy with another project)

Basic concept:
Listen to hermes/intent/#
if it is not the "repeat" skill:
Save the topic and message
if it is the "repeat" skill:
Republish the saved topic with the same message
(Possible problem: The Dialog-ID will be reused!)

Additional Idea:
Don't allow "old" skills to be repeated:
Forget the stored data after a configurable amount of time (Probably via threads so it is really gone)
This could be used for the other skills as well (You don't want your wife to ask Snips what your last sentence was when you are gone ;))

@koenvervloesem
Copy link
Owner

koenvervloesem commented Jan 15, 2019

Yes that's a very natural question and I agree it would fit perfectly in this app. I actually had the same idea a few weeks ago and I even tried to implement it, but the republished intent didn't activate its action. I haven't found the time yet to delve into the issue, but I suspected the duplicate session ID to be the culprit indeed. It would be great if you could have a look at it.

Your additional idea is a great one too. I opened a new issue for it: #3.

@koenvervloesem koenvervloesem changed the title new Feature: Repeat last task New feature: Repeat last task Jan 15, 2019
@koenvervloesem koenvervloesem added the enhancement New feature or request label Jan 15, 2019
@koenvervloesem
Copy link
Owner

Merged in #6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants