New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emit('end') doesn't actually end the stream, it just says "I'm done" #4

Closed

jpeg729 opened this issue Jan 19, 2015 · 1 comment

Contributor

jpeg729 commented Jan 19, 2015

https://github.com/kogakure/gulp-tutorial/blob/master/gulp/util/handleErrors.js#L14

Calling this.end() looks to be a better option, but I'm not an expert.
http://www.bennadel.com/blog/2692-you-have-to-explicitly-end-streams-after-pipes-break-in-node-js.htm

Owner

kogakure commented Jan 19, 2015

Feel free to submit a pull request to improve the code.

kogakure closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment