Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think performance is the biggest problem of ocanvas #157

Open
keel opened this issue Feb 19, 2018 · 1 comment
Open

I think performance is the biggest problem of ocanvas #157

keel opened this issue Feb 19, 2018 · 1 comment

Comments

@keel
Copy link

keel commented Feb 19, 2018

I tried oCanvas a few days and found its so beautiful and elegant, and have a very small size.
But when I run some tests, the FPS makes me so disappointed(already set the fps to 60), especially on android phone.

Then I forked the project and checked the main loop in source code and found some setTimeout functions may slow down the fps, so I removed the fps setting and did some modification in main loop, sprite and animation, and then the fps looks improved a lot , I add some examples to compare the fps(https://github.com/keel/ocanvas/tree/develop/examples).

Also, I add loop and update paras to animate(), so I can make some special effect (examples/animation.html)

I really like oCanvas and hope it used widely, I don't think my work is good enough, so I suggest @koggdal can make some performance improvement , and add unit tests to make it more stable.

@koggdal
Copy link
Owner

koggdal commented Feb 19, 2018

Thanks for considering oCanvas! :)

I don't have much time to work on this project anymore though, so for me this is mostly in maintenance mode. Most of the code is from 2012 or so.. :) I'd be happy to review a PR though in case you want to fix things up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants