Detect line endings when wrapping occurs between elements #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. |
|
Build succeeded. |
| @@ -549,6 +549,37 @@ gui.SelectionControllerTests = function SelectionControllerTests(runner) { | |||
| t.newPosition = getCursorPosition().position; | |||
| r.shouldBe(t, "t.newPosition", "3"); | |||
| } | |||
| function testCountStepsToLineBoundary_Forward_NonTextWrapPoint() { | |||
| // spans actually display as blocks to force the browser to put each text block on it's own line | |||
| createOdtDocument("<text:p>ABC<text:span display='block'>DEF</text:span></text:p>"); | |||
There was a problem hiding this comment.
Is the display='block' attribute a thing? Should this not be CSS?
There was a problem hiding this comment.
The answer lies waiting at line 798 in this file
peitschie
force-pushed
the
line-scan-fix
branch
from
419d6d6
to
4cee761
Compare
|
Build succeeded. |
|
This is a working nice fix. Please rebase and ship it! |
Line ending detection was relying on wrapping occurring near or in a block of collapsed whitespace. When wrapping occurs between two elements, both previous and next rectangles may be defined, though the vertical overlap will be absent.
Line ending detection is still not stable when the wrap point doesn't span a cursor position (as happens when the wrap occurs over whitespace). Fixing this issue is not easy, so these tests demonstrate the current bad behaviour so at least it is somewhat documented.
peitschie
force-pushed
the
line-scan-fix
branch
from
4cee761
to
d0e3e9c
Compare
|
Build succeeded. |
|
Thanks for reviewing this! |
peitschie
added a commit
that referenced
this pull request
Sep 10, 2014
Detect line endings when wrapping occurs between elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line ending detection was relying on wrapping occurring near or in a block of collapsed whitespace. When wrapping occurs between two elements, both previous and next rectangles may be defined, though the vertical overlap will be absent.
Line ending detection is still not stable when the wrap point doesn't span a cursor position (as happens when the wrap occurs over whitespace). Fixing this issue is not easy, so these tests demonstrate the current bad behaviour so at least it is somewhat documented.
Demonstrating line detection problem