Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme toggle support for bookmarklet #256

Closed
0xkarambit opened this issue Aug 19, 2021 · 4 comments · Fixed by #257
Closed

Theme toggle support for bookmarklet #256

0xkarambit opened this issue Aug 19, 2021 · 4 comments · Fixed by #257
Assignees
Labels
enhancement New feature or request

Comments

@0xkarambit
Copy link
Contributor

I just recently tried the bookmarklet and its felt awesome !
is there any way we can add some way to enable theme toggling when using the bookmarklet on other websites ?
Sorry if this already exists, couldnt find it.

@kognise
Copy link
Owner

kognise commented Aug 19, 2021

That's a good idea! I'd been hoping for something like that myself - maybe we can inject some sort of button into the page?

@0xkarambit
Copy link
Contributor Author

ya i was thinking about the same thing !
is it okay if i work on this ?

@kognise
Copy link
Owner

kognise commented Aug 19, 2021

Absolutely! The bookmarklet source code is in bookmarklet/original.js and we've been using this generator I believe.

@kognise kognise added the enhancement New feature or request label Aug 19, 2021
@0xkarambit
Copy link
Contributor Author

yup found that, thanks for the lightning fast response 👍

@kognise kognise linked a pull request Aug 20, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants