rawurldecode request params

[kohamkohane]

Please add rawurldecode to function param() in Kohana/Request. In KO 3.3.3 rawurlencode was added to function uri() in Kohana/Route. I suggest to add rawurldecode when we read these params.

public function param($key = NULL, $default = NULL)
{
    if ($key === NULL)
    {
        // Return the full array
        return $this->_params;
    }

    return isset($this->_params[$key]) ? $this->_params[$key] : $default; // THIS SHOULD BE DECODED
}

[enov]

Hi there @kohamkohane, I am sorry to reply late.

Decoding the URL is the job of the web server. Just did a little test on this on a vanilla Kohana application:

• Changed the action_index of Controller_Welcome to:
  $this->response->body($this->request->param('id'));
• Called the application with this URL:
  http://kohana.dev/index.php/welcome/index/first%20second

received first second with a space between first and second.

I believe you need to rawurldecode only if the URL is not yet processed by the web server (if the URL was retrieved from a database, for example).

Let me know if this settles it.

[kohamkohane]

You are right, but it does not work with internal requests. Then params are not decoded. Maybe the best solution for this issue is deocding URL somewhere in internal requests processing?

[enov]

internal requests

😮 Exactly.

This is how I reproduced the bug: fresh Kohana application, changed Controller_Welcome to:

class Controller_Welcome extends Controller {

    public function action_index()
    {
        $this->response->body(Request::factory('welcome/internal/first%20second')->execute());
    }

    public function action_internal()
    {
        echo $this->request->param('id');
    }
}

and called the application from the browser: http://kohana.dev/index.php/welcome/index.

I got: first%20second

Maybe the best solution for this issue is deocding URL somewhere in internal requests processing

Yes.