Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape special characters in branch URLs #480

Merged
merged 2 commits into from Sep 26, 2019
Merged

Escape special characters in branch URLs #480

merged 2 commits into from Sep 26, 2019

Conversation

martinvanzijl
Copy link
Contributor

Fix for issue #381.

bitwiseman
bitwiseman requested changes May 17, 2019
View reviewed changes
Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Can you add some tests? Then we can merge.

@martinvanzijl @bitwiseman
Issue hub4j#381 - Escape branch URL.
a50a011 
This is using the "old" HTTP.UTF_8 Charset, since the new
StandardCharsets doesn't compile.
@bitwiseman bitwiseman merged commit e740f52 into hub4j:master Sep 26, 2019
@martinvanzijl
Copy link
Contributor Author

Thanks, I'll delete the branch.

@martinvanzijl martinvanzijl deleted the issue_381_branch_url_escaping branch September 26, 2019 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KostyaSha KostyaSha KostyaSha approved these changes

@bitwiseman bitwiseman bitwiseman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martinvanzijl @KostyaSha @bitwiseman