Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run sendctrlc.exe with Java (no console window, simpler code) (#60, #55) #61

Merged
merged 1 commit into from Dec 8, 2018
Merged

run sendctrlc.exe with Java (no console window, simpler code) (#60, #55) #61

merged 1 commit into from Dec 8, 2018

Conversation

segrey
Copy link
Contributor

@segrey segrey commented Nov 22, 2018

Additionally, diagnostics is improved by capturing output stream.

@oleg-nenashev @stephanreiter

@segrey
run sendctrlc.exe with Java (no new console window, simpler code) (je…
be5a29f 
…nkinsci#60, jenkinsci#55)

Additionally, diagnostics is improved by capturing output stream.
@segrey segrey mentioned this pull request Nov 27, 2018
Closed
oleg-nenashev
oleg-nenashev approved these changes Dec 8, 2018
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be OK AFAICT. Will do some testing before the release

@oleg-nenashev oleg-nenashev merged commit c9537f4 into jenkinsci:master Dec 8, 2018
@segrey segrey deleted the run-sendctrlc-with-java branch August 22, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@segrey @oleg-nenashev