Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(discord): improvements #145

Merged
merged 32 commits into from
Mar 4, 2021
Merged

feat(discord): improvements #145

merged 32 commits into from
Mar 4, 2021

Conversation

XxLittleCxX
Copy link
Member

No description provided.

@XxLittleCxX XxLittleCxX marked this pull request as draft March 2, 2021 12:59
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #145 (e012bc9) into develop (cc989ec) will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #145      +/-   ##
===========================================
+ Coverage    90.35%   90.57%   +0.22%     
===========================================
  Files           53       53              
  Lines         9855     9865      +10     
  Branches      1925     1936      +11     
===========================================
+ Hits          8904     8935      +31     
+ Misses         951      930      -21     
Impacted Files Coverage Δ
packages/plugin-eval/src/main.ts 86.29% <0.00%> (-4.84%) ⬇️
packages/plugin-eval/src/index.ts 92.45% <0.00%> (-0.38%) ⬇️
packages/koishi-core/src/parser.ts 92.58% <0.00%> (-0.02%) ⬇️
packages/plugin-teach/src/receiver.ts 95.40% <0.00%> (-0.02%) ⬇️
packages/plugin-teach/src/index.ts 100.00% <0.00%> (ø)
packages/plugin-github/src/events.ts 100.00% <0.00%> (ø)
packages/koishi-test-utils/src/app.ts 100.00% <0.00%> (ø)
packages/koishi-core/src/session.ts 95.21% <0.00%> (+0.01%) ⬆️
packages/koishi-core/src/app.ts 94.81% <0.00%> (+0.05%) ⬆️
packages/koishi-core/src/context.ts 89.09% <0.00%> (+1.03%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc989ec...9bfd4e3. Read the comment docs.

@XxLittleCxX XxLittleCxX marked this pull request as ready for review March 3, 2021 10:37
@XxLittleCxX XxLittleCxX requested a review from shigma March 3, 2021 14:19
packages/adapter-discord/src/utils.ts Outdated Show resolved Hide resolved
packages/adapter-discord/src/utils.ts Outdated Show resolved Hide resolved
packages/adapter-discord/src/utils.ts Outdated Show resolved Hide resolved
packages/adapter-discord/src/utils.ts Show resolved Hide resolved
Copy link
Member

@shigma shigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

然后 conflict 处理一下,有冲突的地方按你写的来就行

packages/adapter-discord/src/index.ts Outdated Show resolved Hide resolved
@shigma shigma merged commit f490732 into koishijs:develop Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants