Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaiheila Adapter: stable ping interval for websocket mode. #187

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

TsFreddie
Copy link
Contributor

Websocket connection should be less likely to drop now.

  • Swaped out setTimeout with setInterval and clear the interval with lazyness.
  • Heartbeat timeout intervals are now 6s, 2s & 4s instead of ms.
  • Added default endpoint config.

Copy link
Member

@shigma shigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #187 (c95a45c) into develop (a78f407) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #187   +/-   ##
========================================
  Coverage    91.12%   91.12%           
========================================
  Files           56       56           
  Lines        10697    10697           
  Branches      2133     2133           
========================================
  Hits          9748     9748           
  Misses         949      949           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a78f407...c95a45c. Read the comment docs.

@shigma shigma merged commit 2b99b08 into koishijs:develop Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants