-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eval): support coffeescript #230
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #230 +/- ##
===========================================
- Coverage 92.38% 92.37% -0.01%
===========================================
Files 56 57 +1
Lines 10794 10823 +29
Branches 2215 2223 +8
===========================================
+ Hits 9972 9998 +26
- Misses 822 825 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
加个测试样例吧,fixture 里面写段 coffee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extractScript 我之后补个单测再说
已更新代码。
辛苦了。 |
是否需要merge一下并解决冲突 |
y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jsx 属于 irrelevant feature,不应该被写进这个 pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.