Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text doesn't reflect accurate quantity if button is pressed fast #9

Open
sanskar10100 opened this issue Jan 7, 2022 · 3 comments
Open

Comments

@sanskar10100
Copy link

Hey @kojofosu, thanks for the awesome lib. Really appreciate your work.

I added version 1.6.4 to an app that I'm building, and I observed that the quantity text doesn't accurately reflect how many times the plus button is clicked.
Check this screen capture:
https://user-images.githubusercontent.com/22092047/148506863-425bafb7-298c-49ea-ba0f-846c1b0a1f15.mp4

But the log indicates that the current quantity has bumped up to 36, instead of 19, which is what's displayed in the text.

2022-01-07 12:49:06.252 20694-20694/com.sanskar.app D/App: Quantity Increased, now item: InventoryItem(maxQuantity=50, name=Perk, price=50, currentQuantity=35)
2022-01-07 12:49:06.393 20694-20694/com.sanskar.app D/App: Quantity Increased, now item: InventoryItem(maxQuantity=50, name=Perk, price=50, currentQuantity=36)

I know it's extremely unlikely that a potential user will perform this kind of action in the app, but I'd still like to prevent any issues in the future. Let me know if I can do anything to fix this issue.

Thanks!

@kojofosu
Copy link
Owner

kojofosu commented Jan 7, 2022

I see... will take a look at it for you.

@sanskar10100
Copy link
Author

sanskar10100 commented Jan 7, 2022

There's one more thing: Is it possible to set a listener of some sort on manual value input? Because I'd like to update some other values when a manual quantity is set.
Please let me know!

@kojofosu
Copy link
Owner

kojofosu commented Jan 7, 2022

sure...that makes sense.. will look into that aswell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants