Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build regression tests and a harness #33

Open
kokes opened this issue Feb 9, 2019 · 2 comments
Open

Build regression tests and a harness #33

kokes opened this issue Feb 9, 2019 · 2 comments

Comments

@kokes
Copy link
Owner

kokes commented Feb 9, 2019

I'm not sure what the best course of action here is. Whether we should just care about DOM generation or if we should go full "screenshot testing" - using Selenium or Puppeteer.

The main reason is to test things like overflows in pres and imgs, multiple outputs, legacy versions etc. Things that tend to break with changes to the library code.

@kokes
Copy link
Owner Author

kokes commented Feb 10, 2019

@kokes
Copy link
Owner Author

kokes commented Feb 10, 2019

This commit 36c745d could be tested for regressions using https://github.com/jupyter/nbconvert/blob/master/nbconvert/tests/files/notebook1.ipynb

@kokes kokes mentioned this issue Feb 8, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant