Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape colons in names #192

Open
ublubu opened this issue Dec 29, 2017 · 0 comments
Open

escape colons in names #192

ublubu opened this issue Dec 29, 2017 · 0 comments

Comments

@ublubu
Copy link
Contributor

ublubu commented Dec 29, 2017

By convention, the names of Kubernetes resources should be up to maximum length of 253 characters and consist of lower case alphanumeric characters, -, and ., but certain resources have more specific restrictions.

https://kubernetes.io/docs/concepts/overview/working-with-objects/names/

Not all names follow this convention, e.g. name: system:serviceaccount:kube-system:dns-controller
We can't use our typical strategy of combining fields with : unless we escape the colons in these names.

The ClusterRoleBinding implementation will include this new behavior, but we need to retrofit other types with the new escaping Name type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant