fix off-by-one in CBC de-/encrypt; don't touch input buffer during CBC encryption #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just remove a useless block copy This undefined behavior has been found during a formal audit by the means of TrustInSoft Analyzer.
fix buffer overflow when input length less than block size
|
Hi Andreas, This is by design. I have omitted checking for valid input, I should have stated that in comments. I will look closer into this. |
|
Oh, glancing over it again, I see not all of it is by design... Sorry for the arrogant answer :/ I'll have a look at fixing this |
|
No worries; I don't see anything arrogant there btw. |
|
@andreas-wehrmann Is this pull request still relevant? I think the bugs may have been fixed. |
|
On 11/21/2017 01:25 AM, kokke wrote:
@andreas-wehrmann Is this pull request still relevant? I think the bugs may have been fixed.
In short: nope.
I guess I should have closed it myself...
Regards
|
|
Hi @andreas-wehrmann I was just checking up after some of the latest updates. I think the padding issues are gone and now the input buffer is leaved untouched as well. |
|
Closing because issue is fixed after merging #76 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBC_encrypt()/CBC_decrypt() wouldn't behave properly if the length was not a multiple of KEYLEN.
Also the input buffer is not modified inplace during CBC_encrypt().